Hacker Newsnew | past | comments | ask | show | jobs | submitlogin

Oh, that's a really good point!

My approach is mostly shaped by my company's culture (which is definitely not one-size-fits-all): if it's a quick thing to code up, I prefer submitting it as a PR with an [RFC] prefix (I've re-titled my PR to include that), so the maintainer knows I'm not too tied to it.

I'll probably lean towards opening issues before PR's in the future though - thanks!



The problem with one-line PRs is that Github forces you to fork the repo first, but I don't want to litter my repository list with forks for one-off contributions.




Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact

Search: