Hacker Newsnew | past | comments | ask | show | jobs | submitlogin

I thought everyone did this. I review twice. For each commit with -v and finally in GH/GL after I open the PR/MR. I often catch something on that last one.

It's rubber ducking.



I self review but I don’t write comments. I simply fix the code as I see the problems that I find self reviewing.


Unfortunately, these days, I am getting a lot of PRs where nobody has read the code, which came straight out of a robot. This makes me really angry.


What is `-v` mean here? I was assuming `git show`, but that doesn't seem to have a `-v` parameter.


`git commit` has a `-v` option that adds the diff to the bottom of the commit message template so you can see it while you write the message.




Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact

Search: